He started his literary career in 1957 with a short story, "Bhaganwale. He became known as a novelist when he published the novel Marhi Da Deeva in 1964. The novel was later adapted into the Punjabi film Marhi Da Deeva in 1989, directed by Surinder Singh. His novel Anhe Ghore Da Daan was also made into a film of the same name in 2011 by director Gurvinder Singh.Singh was honoured with the Padma Shri in 1998and Jnanpith Award in 1999.